Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use app.zyte.com now #432

Merged
merged 3 commits into from
Nov 7, 2023
Merged

use app.zyte.com now #432

merged 3 commits into from
Nov 7, 2023

Conversation

HassanQamar07
Copy link
Member

@HassanQamar07 HassanQamar07 commented Oct 30, 2023 •
edited by Gallaecio
Loading

Resolves #432.

@HassanQamar07 HassanQamar07 mentioned this pull request Oct 30, 2023
Open
@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e6f35c0) 89.29% compared to head (6c97356) 89.26%.

❗ Current head 6c97356 differs from pull request most recent head f72aef8. Consider uploading reports for the commit f72aef8 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #432      +/-   ##
==========================================
- Coverage   89.29%   89.26%   -0.04%     
==========================================
  Files          34       34              
  Lines        2401     2403       +2     
==========================================
+ Hits         2144     2145       +1     
- Misses        257      258       +1
Files Coverage Δ
shub/config.py 96.91% <100.00%> (ø)
shub/items.py 100.00% <ø> (ø)
shub/log.py 100.00% <ø> (ø)
shub/login.py 85.29% <ø> (ø)
shub/requests.py 100.00% <ø> (ø)
shub/utils.py 82.50% <100.00%> (ø)
shub/deploy.py 89.93% <50.00%> (-0.51%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gallaecio
Copy link
Member

The CI issues seems like an actual issue, but unrelated to your PR. How would you feel about addressing it yourself? (in this PR or in a separate one, whichever you prefer)

@rennerocha rennerocha mentioned this pull request Nov 7, 2023
Merged
@rennerocha
Copy link
Contributor

@Gallaecio

I created #433 to fix one of the CI errors (the flake8 related). There are many other tests failing that are totally unrelated to this issue.

I had problems because of the wrong link and it took a while to understand that I can't access app.scraping.com again, otherwise Scrapy Cloud will not work.

Is it possible to merge this PR and try to solve the other issues later?

@Gallaecio Gallaecio requested a review from elacuesta November 7, 2023 12:32
@elacuesta elacuesta merged commit 41c4b1a into scrapinghub:master Nov 7, 2023
15 of 24 checks passed
@elacuesta elacuesta mentioned this pull request Dec 27, 2023
Merged
elacuesta added a commit that referenced this pull request Dec 27, 2023
@elacuesta
schedule command: Scrapinghub -> Zyte
423eb1d 
Missed in #432
@elacuesta elacuesta mentioned this pull request Dec 27, 2023
Merged
elacuesta added a commit that referenced this pull request Dec 27, 2023
@elacuesta
schedule command: Scrapinghub -> Zyte (#437)
d076c6f 
Follow up for #432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elacuesta elacuesta elacuesta approved these changes

@Gallaecio Gallaecio Gallaecio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HassanQamar07 @Gallaecio @rennerocha @elacuesta